Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding info.json for funky40 #8956

Merged
merged 1 commit into from
Apr 28, 2020
Merged

Conversation

TheFourthCow
Copy link
Contributor

adding info.json for funky40 and fixing some technical difficulties. Thanks noroadsleft!

Adding info.json for funky40

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft noroadsleft self-assigned this Apr 28, 2020
@noroadsleft noroadsleft merged commit 0d6614f into qmk:master Apr 28, 2020
@noroadsleft
Copy link
Member

Thanks!

New Instructions:

  1. Hit the Delete Branch button on this page.
    Deletes the branch from GitHub.
  2. Run git fetch -p origin.
    Updates the state of your local repository with the state of your GitHub fork, which in turn tells Git on your computer that this branch was deleted from GitHub.
  3. Run git branch -D funky40_info.
    Deletes the branch from your computer. If it's the branch you have checked out, run git checkout master first.
  4. Update your fork and your local repository by running:
    git checkout master       # changes your branch
    git pull upstream master  # downloads the changes from QMK's repository to your computer
    git push origin master    # uploads the changes on your computer to your fork of QMK Firmware
    

Any time you want to make further changes for a pull request, repeat Step 4, then run git checkout -b <new branch name> (without the brackets) before making your changes. This will make it easier to keep your QMK fork clean as well as make your pull requests easier to review in future.

Enjoy!

@TheFourthCow TheFourthCow deleted the funky40_info branch April 29, 2020 16:20
@TheFourthCow TheFourthCow restored the funky40_info branch April 29, 2020 16:21
@TheFourthCow TheFourthCow deleted the funky40_info branch April 29, 2020 16:22
@TheFourthCow
Copy link
Contributor Author

Thanks!

New Instructions:

1. Hit the `Delete Branch` button on this page.
   Deletes the branch from GitHub.

2. Run `git fetch -p origin`.
   Updates the state of your local repository with the state of your GitHub fork, which in turn tells Git on your computer that this branch was deleted from GitHub.

3. Run `git branch -D funky40_info`.
   Deletes the branch from your computer. If it's the branch you have checked out, run `git checkout master` first.

4. Update your fork and your local repository by running:
   ```
   git checkout master       # changes your branch
   git pull upstream master  # downloads the changes from QMK's repository to your computer
   git push origin master    # uploads the changes on your computer to your fork of QMK Firmware
   ```

Any time you want to make further changes for a pull request, repeat Step 4, then run git checkout -b <new branch name> (without the brackets) before making your changes. This will make it easier to keep your QMK fork clean as well as make your pull requests easier to review in future.

Enjoy!
I followed all the steps, was the info.json file what makes the board compatible with qmk configurator? I dont see the default keymap on that site or is that a different process. Thanks again for all the help!!

violet-fish pushed a commit to violet-fish/qmk_firmware that referenced this pull request May 3, 2020
@noroadsleft
Copy link
Member

I followed all the steps, was the info.json file what makes the board compatible with qmk configurator? I dont see the default keymap on that site or is that a different process. Thanks again for all the help!!

Sorry for the late reply; I've been occupied with other QMK tasks of late.

QMK Configurator's default keymaps live here as JSON files. If you give me some time I can put a default on there (there are instructions out there but I need to update them).

@TheFourthCow
Copy link
Contributor Author

Thanks for the reply, I'd love to learn to do it myself and I can try and follow the instructions but if you can do it whenever you have time I'd really appreciate it, thanks!

@noroadsleft
Copy link
Member

Thanks for the reply, I'd love to learn to do it myself and I can try and follow the instructions but if you can do it whenever you have time I'd really appreciate it, thanks!

The instructions for creating Configurator default keymaps are here:

The parts of that post that I need to document/update:

You can't use default as the value for the keymap key

The Configurator's API was recently updated, and this is no longer true. Go ahead and use default as the value for keymap.

Configurator's UI code only understand one variant of each supported keycode

Also no longer true as of qmk/qmk_configurator#717. Use whichever variant of the supported keycode you like. I personally find the short, seven-characters-or-less variants easier to read, and prefer _______ to KC_TRNS and XXXXXXX to KC_NO, but it no longer makes any difference to Configurator.

bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants